Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [EXPORT] partial cleanup on adding fields to returnProperties based on usage #14788

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 10, 2019

Overview

Minor code cleanup in export - partial of #14782

Before

Less readable

After

More readable

Technical Details

In general we are moving to wrangling information in less places - with the construct generally setting the various properties we need to work with

Comments

@civibot
Copy link

civibot bot commented Jul 10, 2019

(Standard links)

@civibot civibot bot added the master label Jul 10, 2019
@eileenmcnaughton eileenmcnaughton changed the title [REF] partial cleanup on adding fields to returnProperties based on u… [REF] [EXPORT] partial cleanup on adding fields to returnProperties based on u… Jul 10, 2019
@eileenmcnaughton eileenmcnaughton changed the title [REF] [EXPORT] partial cleanup on adding fields to returnProperties based on u… [REF] [EXPORT] partial cleanup on adding fields to returnProperties based on usage Jul 10, 2019
@eileenmcnaughton
Copy link
Contributor Author

@colemanw well this small one is passing now.

@colemanw colemanw merged commit 212eee7 into civicrm:master Jul 10, 2019
@colemanw colemanw deleted the ex2 branch July 10, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants