dev/core#578 follow up fix on activity summary report

[eileenmcnaughton]

Overview

Completes #13540 by getting us past the full group by error

Before

Steps to replicate:

From the standard pre-defined Contact Reports, go to Activity Summary.
Leave Columns as default, with Contact Name not checked.
Leave Grouping as default (Activity Type + Activity Status).
In Sorting, select Contact Name.
Click "Refresh results".

results in error when full group by enabled

After

No error

Technical Details

In #13540 @davejenx tidied up the report to support unit tests and fixed another bug. This completes that by fixing the remaining FGB bug. Note that test coverage does not exactly address this but we have a standard that when fixing a bug in an area of code with poor test coverage it's OK to take us towards having test cover (which Dave did) rather than to cover the specific code break down. This reflects the fact that multiple technical hurdles often need to be over come to bring a report / code path under testing

Comments

https://lab.civicrm.org/dev/core/issues/578

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[davejenx]

Thanks @eileenmcnaughton ! Tested and working here.

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained with a link (Github).
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: Ran report with the specified settings, first replicating the error without the patch, then verifying that the patch resolves the error.
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
    • COMMENTS: As described, test coverage was improved as part of the related PR dev/core/issues/577: Activity Summary report fix for db column count error with section header (without ONLY_FULL_GROUP_BY) #13540.
  • Test results (r-test)
    • PASS: The test results are all-clear.

[eileenmcnaughton]

Thanks @davejenx - merging!