dev/core#578 follow up fix on activity summary report #14745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Completes #13540 by getting us past the full group by error
Before
Steps to replicate:
From the standard pre-defined Contact Reports, go to Activity Summary.
Leave Columns as default, with Contact Name not checked.
Leave Grouping as default (Activity Type + Activity Status).
In Sorting, select Contact Name.
Click "Refresh results".
results in error when full group by enabled
After
No error
Technical Details
In #13540 @davejenx tidied up the report to support unit tests and fixed another bug. This completes that by fixing the remaining FGB bug. Note that test coverage does not exactly address this but we have a standard that when fixing a bug in an area of code with poor test coverage it's OK to take us towards having test cover (which Dave did) rather than to cover the specific code break down. This reflects the fact that multiple technical hurdles often need to be over come to bring a report / code path under testing
Comments
https://lab.civicrm.org/dev/core/issues/578