Removed hardcoded activity status and used Activity create #14720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
jenkins retest this please |
|
This looks good to me, but as far as I can tell this function is not covered by unit tests. Can someone test it manually? |
|
@colemanw have pushed unit test for this. |
|
jenkins retest this please |
|
@civicrm-builder retest this please |
colemanw
reviewed
Jul 4, 2019
| 'activity_type_id' => 'Bulk Email', | ||
| 'status_id' => 'Completed', | ||
| 'subject' => 'Example Subject', | ||
| ], 1); |
There was a problem hiding this comment.
I've seen tests fail when run multiple times in situations like this because after the 1st run there would be more than one activity named "Example Subject".
I like to get around this by doing something like $subject = uniqid('actCreateTest');
There was a problem hiding this comment.
Thanks @colemanw
Just pushed the change
|
This looks good @pradpnayak. |
Added unit test Use unique subject for activity in test
|
@colemanw have squashed the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removed hardcoded activity status and used Activity create
Before
Activity status was hardcoded to 1
After
Used activity status name and api to create activity