-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed hardcoded activity status and used Activity create #14720
Conversation
(Standard links)
|
jenkins retest this please |
This looks good to me, but as far as I can tell this function is not covered by unit tests. Can someone test it manually? |
@colemanw have pushed unit test for this. |
jenkins retest this please |
@civicrm-builder retest this please |
'activity_type_id' => 'Bulk Email', | ||
'status_id' => 'Completed', | ||
'subject' => 'Example Subject', | ||
], 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen tests fail when run multiple times in situations like this because after the 1st run there would be more than one activity named "Example Subject".
I like to get around this by doing something like $subject = uniqid('actCreateTest');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @colemanw
Just pushed the change
This looks good @pradpnayak. |
Added unit test Use unique subject for activity in test
@colemanw have squashed the commits. |
Overview
Removed hardcoded activity status and used Activity create
Before
Activity status was hardcoded to 1
After
Used activity status name and api to create activity