Add unit test demonstrating attaching a listener to queries #14716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
davejenx
reviewed
Jul 3, 2019
| } | ||
| catch (PEAR_Exception $e) { | ||
| $this->assertEquals( | ||
| "SELECT * FROM civicrm_domain [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/* Forgot trailing comment markerSELECT * FROM civicrm_domain' at line 1]", |
There was a problem hiding this comment.
Just wondering if this check could be a bit brittle if the exact text of MySQL's error message changes, or MariaDB diverges from MySQL, or someone runs the test with MySQL in a different locale. Could look for substrings like "nativecode=1064" and "'/* Forgot trailing comment markerSELECT * FROM civicrm_domain'" instead?
|
Jenkins re test this please |
|
@seamuslee001 this can't pass until the other is merged |
|
test this please |
|
Note from the main pr- docs issue outstanding civicrm/civicrm-packages#180 |
|
Test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit test for civicrm/civicrm-packages#180
Before
No test
After
Test
Technical Details
Unit test for civicrm/civicrm-packages#180 pretty much stalled on lack of a test for a long time - this is that test. It will fail until that is merged
I think we can also use this method to resolve https://bugs.mysql.com/bug.php?id=68184 which is an issue where for us truncate is very slow & we have had to hack to DELETE FROM instead
Comments
@seamuslee001 @davejenx