Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query object support for receive_date_high & receive_date_low and generically date fields #14623

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Further fix on the 5.16 work to switch contribution receive_date over to use datepicker object. We have already merged the main change but it was identified in testing that the low & high date values were not filtering correctly.

Before

Choosing from receive date in advanced search not filtering

After

Choosing from receive date in advanced search filtering

Technical Details

@seamuslee001 I believe in general we should be removing special field handling (when we touch the fields) in favour of generic handling - this accepts the field is 'falling through' to default handling & 'clevers that up' to code with dates

Comments

Todo on here - we should add links to related - @seamuslee001 feel free to help on this bit

@civibot
Copy link

civibot bot commented Jun 23, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

@seamuslee001
Copy link
Contributor

I have tested this and seems to work sensibly from my POV and adds a test adding MOP

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 jenkins is no hipster himself!

@eileenmcnaughton eileenmcnaughton merged commit 2bde903 into civicrm:master Jun 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the receive branch June 23, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants