Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] code formatting #14606

Merged
merged 1 commit into from
Jun 23, 2019
Merged

[NFC] code formatting #14606

merged 1 commit into from
Jun 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

IDE code formatting on 2 test classes

Before

array()

After

[]

Technical Details

@colemanw we should do the more thorough format fix too - maybe it's good right after the rc is cut?
Perhaps anytime is good

Comments

@civibot
Copy link

civibot bot commented Jun 22, 2019

(Standard links)

@civibot civibot bot added the master label Jun 22, 2019
@seamuslee001
Copy link
Contributor

Jenkins not happy @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor Author

dang

@eileenmcnaughton eileenmcnaughton force-pushed the format branch 2 times, most recently from b2b12c7 to a056187 Compare June 22, 2019 22:44
@eileenmcnaughton
Copy link
Contributor Author

I fought jenkins and I won

@seamuslee001
Copy link
Contributor

Changes look fine adding MOP

@eileenmcnaughton
Copy link
Contributor Author

unrelated fails

@eileenmcnaughton eileenmcnaughton merged commit 7b6d75b into civicrm:master Jun 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the format branch June 23, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001