dev/core#1047 Fix instance of NULL contamination #14550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 15, 2019
Primarliy consistentcy - also supports checking nullArray is cleared per civicrm#14550
|
Change makes sense to me and seems to be acceptable and i would suspect we have sufficient tests in this area merging |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 15, 2019
Primarliy consistentcy - also supports checking nullArray is cleared per civicrm#14550
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 16, 2019
Primarliy consistentcy - also supports checking nullArray is cleared per civicrm#14550
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 16, 2019
Primarliy consistentcy - also supports checking nullArray is cleared per civicrm#14550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes an unsafe coding practice per https://lab.civicrm.org/dev/core/issues/1047
Before
CRM_Core_DAO::$_nullArray passed
After
CRM_Core_DAO::$_nullArray not passed
Technical Details
Comments
Identified in #14543