Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityForm - Redirect to contact page or activity view in standalone mode #14522

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

colemanw
Copy link
Member

Overview

When using the "standalone" New Activity form, it always redirects to the dashboard after saving. This changes it to redirect to the contact page (if 1 contact) or the activity view screen (if multiple).

Before

New Activity redirects to dashboard after save (in standalone mode).

After

New activity redirects to view the activity, or if it involves a single contact, to their activity tab.

@civibot civibot bot added the master label Jun 13, 2019
@civibot
Copy link

civibot bot commented Jun 13, 2019

(Standard links)

@colemanw
Copy link
Member Author

@demeritcowboy can you review this?

@demeritcowboy
Copy link
Contributor

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
      • It's not specific to this PR just more noticeable during testing this PR because of the focus on the with contact: When you get a validation error it rearranges the order of the with contacts. Everything still works though.
      • Tested standalone and popup for meeting/phonecall. Tested with both creating a separate activity per contact and a single one. Also contribution activity. Tested case activity.
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] Undecided Not sure how you'd write a test for this.
    • [r-test] PASS

@colemanw colemanw merged commit ba0022f into civicrm:master Jun 14, 2019
@colemanw colemanw deleted the ActivityForm branch June 14, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants