Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in uniqueness to cache keys to mitigate clashes on multisite inst… #14485

Merged

Conversation

seamuslee001
Copy link
Contributor

…alls

Overview

in our system we have been seeing some issues where the unique key already exists in the cache database when it goes to try and insert. This aims to try and fix it by adding some uniquness in this case the domain_id to the cache key

Before

CacheKeys could be the same across different domains

After

Cache Keys unique to the specific domain

ping @totten @eileenmcnaughton thoughts?

@civibot
Copy link

civibot bot commented Jun 9, 2019

(Standard links)

@civibot civibot bot added the master label Jun 9, 2019
@seamuslee001 seamuslee001 force-pushed the domain_uniqueness_cache_key branch from b8881e8 to f4de748 Compare June 9, 2019 00:56
@eileenmcnaughton
Copy link
Contributor

This feels consistent with our general cacheKey logic & makes sense - merging

@eileenmcnaughton eileenmcnaughton merged commit 2070fc1 into civicrm:master Jun 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the domain_uniqueness_cache_key branch June 12, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants