-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use crm-checkbox-list styling in display prefs tpl #14461
Conversation
(Standard links)
|
@agh1 you always have opinions about colors :) To try to avoid inventing something new, I reused the visual style of the search pages (where rows are striped and turn yellow when checked). But I think those colors look better on search pages than they do on a settings screen. I don't really like the yellow here. Open to suggestions. OTOH I don't think this PR needs to get held up by color choices, as the colors are not part of the PR per-se. IMO we can merge this and keep discussing it. |
Does it need colors? |
@colemanw it's a lot of yellow, but at least for now @MegaphoneJon I can see it being kind of nice to have a highlight on selected lines in this sort of hybrid multiselect-checkbox. The background has that grey striping, so it makes sense that it's some other color. |
I suppose this form is also a bit of an outlier because you frequently want all the things--meaning it's all yellow. |
I'm going to merge this as a standardisation & invite a follow up on the YELLOW from clever styly people (like @vingle or perhaps a Compucorp peep @mickadoo @jamienovick |
Thanks @eileenmcnaughton. tbh, I find it hard to discuss the yellow without mentioning the beige. |
@vingle don't mention the Beige - as Basil would say |
Some of my best friends like Beige! In short: alternating row colours = good, and tidier checkbox lists = good. But beige with yellow is poutine without the gravy, tho that's maybe another thread. |
This might be as good a place as any to mention that while pulling this wiki page on interface together earlier, I stumbled across the shoreditch colour guide. I don't know if there's a Civi color palette somewhere to reference, but it'd be nice (even if it looks like lunch in a retirement home :). |
@vingle cool |
@vingle any styling tips welcome if you want to take a look at my angular bootstrap foray into a 'quicker to use' dedupe form https://github.com/eileenmcnaughton/org.wikimedia.dedupetools |
@eileenmcnaughton looks good to me from the screengrab. Maybe some padding around the top elements? ie 5-10px top and bottom of elements, and (at a guess) 30px from the left to align with the non bob title. I like the batch merge thunderbolt icon. |
@vingle my coworker put together a list of colors in civicrm.css five years ago and it was mayhem: https://issues.civicrm.org/jira/browse/CRM-15515 I don't think much has been done to standardize it since then except that people have been better about not inventing new colors to add to it. |
@vingle How do I edit that wiki page? |
@christianwach - you first need to become a member of the Interface project - which might mean joining the Dev Group, as I think permissions get inherited from there. |
@agh1 ah nice, thanks - the links on that page 404 tho. @mlutfy - I don't suppose you know if there's a backup of the three files linked to here, e.g. https://issues.civicrm.org/jira/secure/attachment/30373/colorsofcivicrm.html, https://issues.civicrm.org/jira/secure/attachment/30374/Civi%20Color%20Index-1.ods & https://issues.civicrm.org/jira/secure/attachment/30372/newcolors.html ? |
@vingle Hmm, I'm a maintainer of WordPress which is a project in Dev, but weirdly I don't seem to be a member of Dev. How do I go about getting added to Dev and/or Interface? |
@vingle hopefully @mlutfy can find it. Until then, I used the pigments package in Atom which produced a list of all the colors in civicrm-core. Github now has a little color preview for hex colors so this might give a taste of how things are. 550 colors found in 19 files ang/crmAttachment.css (1)6 border: 1px solid red ; ang/crmCaseType.css (1)25 background: ang/crmMailing.css (6)17 background: ang/crmMailingAB.css (3)2 background: ang/crmStatusPage.css (6)4 color: white ; css/admin.css (10)9 border-right: 1px solid css/backdrop.css (3)5 background-color: css/bluemarine.css (57)9 color: css/civicrm.css (307)42 color: css/contactSummary.css (22)21 border-bottom: 1px solid css/crm-menubar.css (19)35 border-bottom: 1px solid css/crm.designer.css (19)5 border: 1px solid black ; css/dashboard.css (19)28 border: 3px dashed css/joomla.css (30)24 border: 1px solid gray ; css/joomla_frontend.css (4)2 background-color: css/print.css (9)9 border: 1px solid grey ; css/searchForm.css (6)14 border: 1px solid install/template.css (19)2 background: css/Audit/style.css (9)23 color: |
Added Haystack as 'dev' on the dev project, which should make it possible to edit all wikis, and added nicol as maintainer of 'interface'. |
Thanks @mlutfy |
Overview
As a followup to #14419, this restyles the rest of the checkboxes on "Display Preferences" screen for visual consistency.
Before
After
Comments
It's a lot of yellow. Not sure what to do about that. Open to suggestions.