(NFC) Remove without param tests #14454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These really date back to when we were creating the api wrapper. I don't think they add much value now - esp since php is not quiet if we break the wrapper contract
|
(Standard links)
|
Agree. Also, the change doesn't change the behavior of the code and it doesn't change the specification of how the functions work, so I think we can squeeze this in under NFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove syntax conformance tests not really compatible with php 7.0
Before
tests failing
After
tests gone
Technical Details
These really date back to when we were creating the api wrapper. It's a lot of tests to handle something like that. I don't think
they add much value now - esp since php is not quiet about this sort of bug anymore!
Comments