Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1015 fix regression on exporting soft credits #14453

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 6, 2019

Overview

Fixes regression on exporting soft credits

Before

Fatal error

After

Works & tested

Technical Details

Regression because
7f59431#diff-e54381bfdf51e31cab376c71ca0d66ffR2716
removed a space that was required when exporting soft credits. Test added & the fix makes the addition of a space in
a more sensible way (doesn't rely on it being done correctly in dozens of places

Comments

Cut down from #14440 and #14446 due to test fails

@civibot
Copy link

civibot bot commented Jun 6, 2019

(Standard links)

@totten
Copy link
Member

totten commented Jun 6, 2019

Note: I haven't tested this one myself, but I believe the substantive change was checked by two people (Eileen and Seamus) in previous PRs. The distinguishing quality of this PR is just focused on the intra-test-suite issues; given that this is a recent-regression and that we've got a pending release, it seems ok to punt on the intra-test-suite issue.

@totten totten merged commit d8d688d into civicrm:5.14 Jun 6, 2019
@eileenmcnaughton eileenmcnaughton deleted the export_sc_514 branch June 6, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants