(dev/core#1000) Fixes contact's displayname not appearing in membership edit, if no registered email is found #14438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This was referenced Jun 5, 2019
Closed
totten
reviewed
Jun 5, 2019
| @@ -164,7 +164,7 @@ public function testBatchMergeSelectedDuplicates() { | |||
|
|
|||
| // Retrieve pairs from prev next cache table | |||
| $select = array('pn.is_selected' => 'is_selected'); | |||
| $cacheKeyString = CRM_Dedupe_Merger::getMergeCacheKeyString($dao->id, $this->_groupId); | |||
| $cacheKeyString = CRM_Dedupe_Merger::getMerge1CacheKeyString($dao->id, $this->_groupId); | |||
There was a problem hiding this comment.
@eileenmcnaughton PHP fatal:
Fatal error: Call to undefined method CRM_Dedupe_Merger::getMerge1CacheKeyString() in /home/jenkins/bknix-dfl/build/core-14438-2q0bb/sites/all/modules/civicrm/tests/phpunit/CRM/Dedupe/MergerTest.php on line 167
…egistered email is found Add a unit test to lock in fix to dev/core#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When someone edits a contact's membership and that contact has no registered email, membership displays no contact name in membership edit mode.
Before
No
display_nameis coming back from the call toCRM_Contact_BAO_Contact_Location::getEmailDetailsAfter
display_namereturns properly (along with an email, if available)Technical Details
Rework on API call
Email.get(becomesContact.getalong with API Chain toEmail.get)Comments
Related issue here
Pulls #14429 & #14374 into one PR against the rc