Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum supported PHP version is 7.0 #14437

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Minimum supported PHP version is 7.0 #14437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CRM/Upgrade/Form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ class CRM_Upgrade_Form extends CRM_Core_Form {

/**
* Minimum php version required to run (equal to or lower than the minimum install version)
*
* Even though 5.6 is no longer supported, this value is left here for a while
* so as not to block stragglers from upgrading.
Copy link
Member

@totten totten Jun 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on this incrementalism.

Tangentially... there are actually several "installers" (i.e. the typical D7/WP web-installer; the Joomla and drush and wp-cli installers; the setup.sh and civicrm_install() bash scripts) which each enforce different constraints, and those can be viewed as "stragglers" of another sort. We should eventually fix those too, but not by playing whack-a-mole specifically on the PHP version check. Rather, we should push forward on consolidating the installer code so that it's easier to maintain the installer logic generally.

But that's all tangential.

This PR seems like a fair and simple way to phase-in the elevated requirement.

*/
const MINIMUM_PHP_VERSION = '5.6';

Expand Down
2 changes: 1 addition & 1 deletion CRM/Upgrade/Incremental/General.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class CRM_Upgrade_Incremental_General {
*
* @see install/index.php
*/
const MIN_INSTALL_PHP_VER = '5.6';
const MIN_INSTALL_PHP_VER = '7.0';

/**
* Compute any messages which should be displayed before upgrade.
Expand Down