Revert "Create contribution before taking payment, per contribution page workflow" #14435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age workflow" This reverts commit 9257f12
|
(Standard links)
|
|
Given Eileen's concern in regards to issue i'm going to merge this PR to back out the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This reverts commit 9257f12 #13837 & switches the code handling of credit card payments back to being unchanged from 5.13
It's backing out a change that would otherwise have been in 5.14 because I don't think it's safe enough
Before
Credit card handling had been stdised but caused a regression
After
Change that would have been in 5.14 now backed out
Technical Details
@mattwire this has been playing on my mind because I didn't feel that we have really good test cover on events or that this really got put through it's paces & tested really thoroughly.
@kcristiano did do some rc testing on it but I did my own just now & found that the payments do NOT show correctly with this patch applied - ie the payment is present in the screen shot below but missing without the patch. Rather than try to deal with it in a rush I'm just reverting so that there will not be a change in 5.14. It's disappointing not to get to having a reliable flow on this but if you compare to the conversion on contribution we built up a pretty substantive bank of tests first & we never got there on events
Comments