Add angular-xeditable to angular #14414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my digging xeditable seems like the main option for angular edit in place https://vitalets.github.io/angular-xeditable/#overview I think it makes sense to ship with core & sooner rather than later so we don't get in muddles with different versions in extensions My sample afform using this is here totten/afform#15
|
(Standard links)
|
|
test this please |
|
Test fail unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add angular xeditable component to our bower_components
Before
Not present
After
Present
Technical Details
From my digging xeditable seems like the main option for angular edit in place
https://vitalets.github.io/angular-xeditable/#overview
I think it makes sense to ship with core & sooner rather than later so we don't get
in muddles with different versions in extensions
My sample afform using this is here
totten/afform#15
Comments