dev/core#389 [preliminary cleanup+ test] Standardise metadat for custom field #14401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
13258de to
a9fdce6
Compare
a9fdce6 to
17e9c5f
Compare
…ld use In digging into dev/core#389 I found a major complexity in fixing it was inconsistent metadata available at different points in the code. This simply adds metadata to the 'inner-most place' & makes the BAO_CustomQuery object use that I didn't remove the options loop because I wanted to leave that out of scope as I can't see how / if it is used [test] add test for getImportableFields
17e9c5f to
96a3c9a
Compare
|
Test fail relates @eileenmcnaughton |
96a3c9a to
cef2e96
Compare
|
hopefully this time |
|
@seamuslee001 ok it passed this time |
|
Changes make sense here standardising output and has good test coverage merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make metadata for custom fields more consistent, add test
Before
Less consistent
After
More consistent
Technical Details
In digging into dev/core#389 I found a major complexity in fixing it was inconsistent metadata available at different
points in the code. This simply adds metadata to the 'inner-most place' & makes the BAO_CustomQuery object use that
I didn't remove the options loop because I wanted to leave that out of scope as I can't see how / if it is used
Comments