Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new inactive statuses as 'Chargeback' does not exist on new installs and that breaks Contributionrecur.create API #14398

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Jun 1, 2019

Overview

Following #14343 the recurring contributions tab is showing no results because the "Chargeback" status does not exist on new installs.

Before

Recurring contributions tab shows no results.

After

Recurring contributions tab shows results as before. Inactive statuses updated to match new option group.

Technical Details

Comments

@eileenmcnaughton Unreleased regression

…lls and that breaks Contributionrecur.create API
@civibot
Copy link

civibot bot commented Jun 1, 2019

(Standard links)

@civibot civibot bot added the master label Jun 1, 2019
@mattwire
Copy link
Contributor Author

mattwire commented Jun 1, 2019

test this please

@eileenmcnaughton eileenmcnaughton merged commit 418ea32 into civicrm:master Jun 1, 2019
@eileenmcnaughton
Copy link
Contributor

looks good to me

@eileenmcnaughton
Copy link
Contributor

(I do wish we could easily override these as having 'completed' off the 'active' tab is annoying for us. Actually I wish they were all on the same tab TBH...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants