CRM_Extension_System - Only allow test.* extensions during headless testing. Hide from regular users.
#14392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function allows one to filter down the list of extensions which are visible. A few notes: * The result of the scanning/filtering is stored in cache. On a typical page-load, the system uses this cache -- which happily means that filtering shouldn't result in any extra page-load time. * The extension-system is generally boot-critical. I could imagine some scope-creep around making making the filter mechanism hookable, but that's a separate+complicated issue. Optimistically... if `array $containers` somehow becomes hookable, then one could use the same mechanism to manipulate the filters.
…st sites The headless test suite includes integration tests for correct handling of the extension installation/removal process. This involves some dummy extensions. Unfortunately, the dummy extensions are often picked up on live deployments -- where they're a bit distracting/annoying. Before ------ The `test.*` dummy extensions appear as available in all environments, including headless tests and live sites. After ----- The `test.*` dummy extensions are only available in the headless test environment.
|
(Standard links)
|
|
sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headless test suite includes integration tests for correct handling of the extension installation/removal process. This involves some dummy extensions. Unfortunately, the dummy extensions are often picked up on other deployments -- where they're a bit distracting/annoying.
Before
The
test.*dummy extensions appear as available in all environments, including headless tests and live sites.After
The
test.*dummy extensions are only available in the headless test environment.Comments
The extension list is used on every page-load, so one might be concerned: what's the performance impact of adding more filters to this scan process? Fortunately, the output of the scanning is cached post-filtering -- so there should be no discernible penalty.