Fix fatal error when using the "Renew - Credit Card" form to renew a membership (only for certain membership setups)

[alifrumin]

Overview

This fixes a fatal error when renewing a membership on the backend thru the "Renew - Credit Card" form

Before

Fatal error

After

Form works as expected

Technical Details

In some instances the receive date was not being set on the contribution which would lead to a fatal error when submitting the form. This ensures the receive date is set.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@alifrumin what version was this causing problems on?

[alifrumin]

I was able to replicate it on 5.14.beta1, however only when renewing a kind of odd membership set up.

[eileenmcnaughton]

@alifrumin is this on master too - it looks similar to this fix #14316 that was merged to master 6 days ago (I never hit the bug in the UI - only in tests)

[seamuslee001]

@alifrumin @eileenmcnaughton i ran into this bug on AUG systems and tested Eileen's patch and confirmed that fixed it in our case. @eileenmcnaughton wanna do a RC backport of 14316?

[eileenmcnaughton]

Closing in favour of #14412

[alifrumin]

Thanks @eileenmcnaughton and @seamuslee001 I just tested and #14412 fixes this for our use case too.