dev/core/issues/991, fixed set default values for find contact search form

[pradpnayak]

Overview

https://lab.civicrm.org/dev/core/issues/991

Before

After

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[scardinius]

@pradpnayak no, this fix doesn't resolve my problem in https://lab.civicrm.org/dev/core/issues/991

[pradpnayak]

@scardinius i believe it does fix the setting default values on the Find contact form.

[pradpnayak]

jenkins retest this please

[seamuslee001]

@eileenmcnaughton thoughts on this given the general changes to search forms?

[eileenmcnaughton]

I took a look at this & agree it doesn't work because now (not necessarily always) - contact basic search is not used to load a search for a smart group from a basic search.

I took a look at a better fix & it's tough - I think we probably want to think a bit more through the stored & unstoring of smart groups - essentially the advanced search should be responsible for 'packing & unpacking' the groups it stores as saved searches. I feel like a bit of cleanup & digging is required to get us there though

I did add this earlier as a preliminary simplification
#14891

I'm going to close this because it doesn't get us there :-(