dev/core996 Ensure that the oldest created_date is retained no matter… #14368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
| @@ -894,6 +922,7 @@ public function setupMatchData() { | |||
| foreach ($fixtures as $fixture) { | |||
| $contactID = $this->individualCreate($fixture); | |||
| $this->contacts[] = array_merge($fixture, ['id' => $contactID]); | |||
| sleep(20); | |||
There was a problem hiding this comment.
Can we get away with 5 or 10?
There was a problem hiding this comment.
Yeh i guess i was wanting something 'meaningful'
… the ids of the contacts being merged Reduce sleep to 5
ae778be to
1f0138d
Compare
|
This is is a horrible fix - and as such it's totally in keeping with the surrounding code. It adds test coverage so I'm happy to merge, knowing that we can keep cleaning up the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the ids of the contacts being merged
Overview
When contacts are flipped around during merge it is possible that the oldest created_date gets lost in the merge process this fixes it
Before
oldest created date may get lost
After
oldest created date is always retained
ping @eileenmcnaughton @mattwire @lcdservices @JKingsnorth @andrew-cormick-dockery @johntwyman