Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] move calculation of migrationInfo into the function that uses it #14365

Merged
merged 1 commit into from
May 29, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Very minor code cleanup

Before

Less readable

After

More readable

Technical Details

This doesn't make a lot of sense as a passed parameter & it's better to derive it closer to where it's used.

It's also kinda silly....

Comments

@civibot civibot bot added the master label May 28, 2019
@civibot
Copy link

civibot bot commented May 28, 2019

(Standard links)

This doesn't make a lot of sense as a passed parameter & it's better to derive it closer to where it's used.

It's also kinda silly....
@seamuslee001
Copy link
Contributor

Change seems to make sense there should be enough test coverage here that we are would see any failures from this

@seamuslee001 seamuslee001 merged commit b7955ca into civicrm:master May 29, 2019
@seamuslee001 seamuslee001 deleted the dedupe_move branch May 29, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants