Fix bug where contribution status is mishandled if label is changed #14352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Change looks safe. Good to merge. |
|
thanks @pradpnayak |
|
Test fails relate @eileenmcnaughton |
fc8c098 to
adc5ad2
Compare
|
@seamuslee001 yeah - that was an experiment... |
adc5ad2 to
0a20185
Compare
|
@eileenmcnaughton |
|
thanks @yashodha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug where the handling of contribution code relies on label rather than name. This could cause obscure bugs
Before
Comparison is label based
After
Comparison is name based, tested
Technical Details
I also stuck in a couple of deprecation warnings to see what happens... This might come out again
Comments
@mattwire yeah that label thing you spotted was probably pretty bad