Fix fatal error when full group by mysql mode enabled & selecting contacts #14331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Contact/BAO/Query.php
Outdated
| @@ -4971,7 +4972,9 @@ public function getCachedContacts($cids, $includeContactIds) { | |||
| $limit = ''; | |||
| $query = "$select $from $where $groupBy $order $limit"; | |||
|
|
|||
| return CRM_Core_DAO::executeQuery($query); | |||
| $result = CRM_Core_DAO::executeQuery($query); | |||
| CRM_Core_DAO::disableFullGroupByMode(); | |||
There was a problem hiding this comment.
this doesn't look right @eileenmcnaughton
There was a problem hiding this comment.
erm yep, fixed
|
Jenkins re test this please |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
May 26, 2019
|
Unit test added here #14340 |
seamuslee001
added a commit
that referenced
this pull request
May 26, 2019
Unit test for FGB error in #14331
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a fatal error under some circumstances.
To replicate - on a server with full group by mysql mode enabled do a contact search. Select a contact & click next
Before
After
No fatal
Technical Details
Disable full group by when selecting contacts. Per the screen shot the query is pretty non-std & it makes sense fgb mode rejects it - this is our std solution
Comments