Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] minor code re-org #14318

Merged
merged 1 commit into from
May 25, 2019
Merged

[REF] minor code re-org #14318

merged 1 commit into from
May 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Very minor code cleanup

Before

Less readable

After

More readable

Technical Details

This simply moves the blocks that are wrapped in if ( == 'changedStatus') into
one block & puts them directly after the block which handles early returns for (some)
status changes

Comments

@eileenmcnaughton
[REF] minor code re-org
ea2ca75 
This simply moves the blocks that are wrapped in if ( == 'changedStatus') into
one block & puts them directly after the block which handles early returns for (some)
status changes
@civibot
Copy link

civibot bot commented May 24, 2019

(Standard links)

@civibot civibot bot added the master label May 24, 2019
@mattwire mattwire merged commit 148b2b7 into civicrm:master May 25, 2019
@eileenmcnaughton eileenmcnaughton deleted the reorg branch May 25, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @mattwire