Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare API Key as a protected field for future use #14274

Merged
merged 1 commit into from
May 21, 2019
Merged

Declare API Key as a protected field for future use #14274

merged 1 commit into from
May 21, 2019

Conversation

seamuslee001
Copy link
Contributor

Overview

This just in the fields array declares that the API Key field is a "protected" field

ping @eileenmcnaughton

@civibot civibot bot added the master label May 20, 2019
@civibot
Copy link

civibot bot commented May 20, 2019

(Standard links)

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001 seamuslee001 mentioned this pull request May 20, 2019
Closed
@eileenmcnaughton
Copy link
Contributor

This seems safe - it doesn't actually change visibility, it just adds metadata

@seamuslee001 seamuslee001 merged commit 8f35ee6 into civicrm:master May 21, 2019
@seamuslee001 seamuslee001 deleted the protected_fields_dao branch May 21, 2019 00:28
@colemanw
Copy link
Member

Per my comments on #14275 I think this needs more discussion about not just whether a field is protected, but how.

This was referenced Jun 27, 2019
Merged
Merged
totten pushed a commit that referenced this pull request Nov 20, 2019
@totten
Backport for security/core#62 (api_key)
99936ab 
Incl #14679 #14274 and #14660 and MR \!76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @eileenmcnaughton @colemanw