Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#980 [test-dbunit] Remove some use of dbunit from tests #14271

Merged
merged 3 commits into from
May 20, 2019
Merged

dev/core#980 [test-dbunit] Remove some use of dbunit from tests #14271

merged 3 commits into from
May 20, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Per #14268 this removes some places where tests use discontinued dbunit classes & in these cases they seem to add little to no value

Before

DB unit class used

After

Not used

Technical Details

There are a handful of places where the function to use an xml dataset are used. Working through them...

Comments

@civibot
Copy link

civibot bot commented May 20, 2019

(Standard links)

@civibot civibot bot added the master label May 20, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the db_test_towards branch 2 times, most recently from 28c50a8 to eb47bfb Compare May 20, 2019 03:53
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

@colemanw @seamuslee001 can one of you merge?

@seamuslee001
Copy link
Contributor

Only affects tests and Jenkins has passed it merging

@seamuslee001 seamuslee001 merged commit 5722a07 into civicrm:master May 20, 2019
@eileenmcnaughton eileenmcnaughton deleted the db_test_towards branch May 20, 2019 23:09
@eileenmcnaughton eileenmcnaughton changed the title [TEST SUITE] Remove some use of dbunit from tests [test-dbunit] Remove some use of dbunit from tests May 21, 2019
@eileenmcnaughton eileenmcnaughton changed the title [test-dbunit] Remove some use of dbunit from tests dev/core#980 [test-dbunit] Remove some use of dbunit from tests May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001