Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testGetActivityAccessCiviCRMEnough test for clarity #14226

Merged
merged 1 commit into from
May 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Updates a test for clarity

Before

test is misleading

After

Updates an old test to make it clear what is happening

Technical Details

'access CiviCRM' should be enough to call Activity.getsingle. However, the test should still fail as non are fetched, this clarifies & also adds a getcount

Comments

@pradpnayak I did this in conjunction with a chat question I understand you are digging into

@civibot civibot bot added the master label May 10, 2019
@civibot
Copy link

civibot bot commented May 10, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

test makes sense merging

@seamuslee001 seamuslee001 merged commit 7e3b797 into civicrm:master May 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the master branch May 12, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants