Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF Refactor to reduce duplication on payment forms #14206

Merged
merged 1 commit into from
May 12, 2019

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented May 6, 2019

Overview

Share a little bit more code, reduce duplication

Before

Duplicated code for frontend/backend forms. Some called twice.

After

Shared code for frontend/backend forms. Less called twice.

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 6, 2019

(Standard links)

@civibot civibot bot added the master label May 6, 2019
@eileenmcnaughton
Copy link
Contributor

@mattwire this makes sense to me as the code is centralised more.

Bigger picture what should we do? I feel like maybe the payment form functions should be in a trait?

@eileenmcnaughton eileenmcnaughton merged commit 5489f15 into civicrm:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants