(dev/core#705) Disabling Alphabetical Pager is not respected for events

[yashodha]

Overview

Steps to replicate :

Go to Admin > Search Preferences and turn off Include Alphabetical Pager

A to Z Pager is off for Find Contacts, Find Contributions, etc
However it is still shown on Manage Events.

https://lab.civicrm.org/dev/core/issues/705

Before

Alphabetical Pager is visible on Manage Events

After

Alphabetical Pager is not visible on Manage Events

Comments

This is keeping it consistent with other selectors where Alphabetical Pager is already suppressed. This is in continuation of #13592

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I wonder if we could do this check in the pagerAToZ function & not everywhere else - seems like you have found a few that got missed & hard to imagine there aren't more. Plus it would be less code duplication

[yashodha]

@eileenmcnaughton
makes sense, will check

[yashodha]

@eileenmcnaughton

I don't think we could centralise this more since each of these have their own pagerAToZ method.
https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/Page/ContributionPage.php#L676

[eileenmcnaughton]

Sigh - of course they do...

I suspect we could pass in table or something as well but OK - let's not blow this up

Oh by the way - that query you linked to is 'bad'

    $query = "
SELECT DISTINCT UPPER(LEFT(title, 1)) as sort_name
FROM civicrm_contribution_page
WHERE $whereClause
ORDER BY UPPER(LEFT(title, 1))
";

The use of UPPER will block indexing. Handling casing in the php layer speeds up queries. (I doubt anyone has so many contribution pages this is really hurting them although @seamuslee001 has a few.....)