Pass the RFC 3164 severity level thru to drupal watchdog. #14185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
At the moment I am on sabbatical so working on civicrm less than usual, but feel free to suggest something anyways and I'll help out as time permits. |
mattwire
reviewed
May 9, 2019
| @@ -617,7 +617,7 @@ public static function debug_log_message($message, $out = FALSE, $prefix = '', $ | |||
| if (!empty(\Civi::$statics[__CLASS__]['userFrameworkLogging'])) { | |||
| // should call $config->userSystem->logger($message) here - but I got a situation where userSystem was not an object - not sure why | |||
There was a problem hiding this comment.
@mfb It would be nice to try and resolve this comment
|
Tested this and it works well. |
|
Interestingly that logger method doesn't have a parameter for severity
level - we could add one in another PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When passing log messages thru to Drupal watchdog(), CRM_Core_Error::debug_log_message() logs everything at debug level. However, Pear Log and Drupal both use the same RFC 3164 numeric severity levels. Therefore, we could pass the severity level thru to watchdog().
Before
Everything is logged at debug level.
After
Errors, warnings, notices, info, etc. can be logged appropriately.