Event Cart: pass the contactID to fix payment on Stripe

[mlutfy]

Overview

When using the Stripe payment processor with the Event Cart, it was not possible to complete the checkout process. When submitting the payment form, it would just loop back to the main form, without any visible error.

Technical Details

I eventually managed to find an exception : Stripe Customer (find): contact_id is required.

And related issue: https://lab.civicrm.org/extensions/stripe/issues/16

The Cart Checkout does not do the same trick as the Event Payment does, so I figured it was simpler to fix it this way.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

test this please

[mattwire]

Question for @eileenmcnaughton What is the preferred syntax for contact ID key in the array? Referencing https://lab.civicrm.org/extensions/stripe/blob/master/CRM/Core/Payment/StripeTrait.php#L51 My "preference" is contact_id but we have quite a few at the moment..

Also @mlutfy If you have the opportunity to do a PR for the normal event payment then we can get rid of this nasty hack: https://lab.civicrm.org/extensions/stripe/blob/master/CRM/Core/Payment/StripeTrait.php#L64

[eileenmcnaughton]

@mattwire yeah I tried to get agreement on that once under Lobo - I failed - although the general interest on standardisation was lower then.

I prefer

• contact_id in an array & $contactID as a variable - but I think I sometimes use $contact_id too - not sure.

I'm too old fashioned to support $contactId

[mattwire]

@mlutfy So if you can change it to $params['contact_id'] (unless you have any strong objections :-) ) then I think we're good to merge this.

[mlutfy]

done!

[eileenmcnaughton]

unrelated fail