Event Cart: fix sending of email receipts

[mlutfy]

Overview

When using the Event Cart, the configuration emails would cause a fatal error.

To reproduce, one needs to enable the Event Cart (Administer > CiviEvent > Event component settings), setup an event, add to cart and checkout.

Technical Details

This looks like a terrible solution, but it's what CRM/Contact/Form/Task/EmailCommon.php does.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

This looks like a terrible solution, but it's what CRM/Contact/Form/Task/EmailCommon.php does.

@mlutfy Is there scope here for sharing the emailReceipt() function?

[mlutfy]

odd unrelated test fail:

api_v3_AttachmentTest::testCreate with data set #0 ('CRM_Activity_DAO_Activity', array('test_NssIC_exampleFromContent.txt', 'text/plain', 'My test description', 'My test content'), 'My test content')
Expect field url to match
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'http://core-14170-was5.test-1.civicrm.org:8001/index.php?q=civicrm/file&reset=1&id=1&eid=1&fcs=a1ab9ac53c39bb5bf3443329f3376b7924cbbf6b7681d65e71bd05c405115a6e_1556709866_168'
+'http://core-14170-was5.test-1.civicrm.org:8001/index.php?q=civicrm/file&reset=1&id=1&eid=1&fcs=a1ab9ac53c39bb5bf3443329f3376b7924cbbf6b7681d65e71bd05c405115a6e_1556709867_168'

/home/jenkins/bknix-dfl/build/core-14170-was5/sites/all/modules/civicrm/tests/phpunit/api/v3/AttachmentTest.php:335
/home/jenkins/bknix-dfl/build/core-14170-was5/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:201
/home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598

[mlutfy]

This looks like a terrible solution, but it's what CRM/Contact/Form/Task/EmailCommon.php does.
@mlutfy Is there scope here for sharing the emailReceipt() function?

Was there any refactoring already done in that area? It seems like every entity has their own emailReceipt function, but they're all a bit different. (one could argue they are wrappers over sendMail)

[mlutfy]

jenkins, test this please

[eileenmcnaughton]

Per comments elsewhere - we can't have the same review bar for event cart because the code ahs always been kinda-alpha-y - & we have no reviewers / experts in this code - merging this based on reading the code & it making sense