dev/core#918 Enotice fix #14165
Merged
dev/core#918 Enotice fix #14165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check is looking for status at the wrong level in the array
|
(Standard links)
|
|
looks fine to me adding merge on pass |
|
Unfortunately, changing the line of merge didn't work for me. Its a clean install I am trying on. now getting this message
|
|
@tapashdatta You are right - a change I made locally is missing so I must not have pushed it up... one minute |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
May 1, 2019
|
@tapashdatta check this #14168 |
|
Yes, That worked! thanks. |
mattwire
added a commit
that referenced
this pull request
May 1, 2019
dev/core#918 enotice fix part 2 #14165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a notice / fail in the Financial type acl check - The check is looking for status at the wrong level in the array
Before
Error randomly appearing when Financial type ACL is enanled
Notice: Undefined index: status in CRM_Utils_Check_Component_FinancialTypeAcls::checkFinancialAclReport() (line 39 of /home/webadmin/public_html/cmm-uat/sites/all/modules/civicrm/CRM/Utils/Check/Component/FinancialTypeAcls.php).
Also, in system status keep saying Extension missing, although its installed.
After
Error gone, extension correctly identified as installed
Technical Details
Comments
https://lab.civicrm.org/dev/core/issues/918