Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation handling [intra-rc-follow up] on #13999] #14164

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

The signature for CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution was altered in 5.13 ( 9cfc631) to expect an array. Out of concern for sites calling the BAO directly from extensions we added deprecation handle to make it succeed naughtily

Turns out we were one of the sites naughtily using the BAO directly who needed this handling
to work - but because we passed a number in quote it didn't - this fixes

Before

Deprecation handling works for 5 but not '5'

After

Deprecation handling works for 5 and '5'

Technical Details

Comments

We don't support calling the BAO directly but somethings we kinda try to be helpful anyway

Turns out we were one of the sites naughtily using the BAO directly who needed this handling
to work - but because we passed a number in quote it didn't - this fixes
@civibot civibot bot added the 5.13 label Apr 30, 2019
@civibot
Copy link

civibot bot commented Apr 30, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

change makes sense adding merge on pass

@eileenmcnaughton eileenmcnaughton merged commit f77a81c into civicrm:5.13 Apr 30, 2019
@eileenmcnaughton eileenmcnaughton deleted the in_fix branch April 30, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants