Fix deprecation handling [intra-rc-follow up] on #13999] #14164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The signature for CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution was altered in 5.13 ( 9cfc631) to expect an array. Out of concern for sites calling the BAO directly from extensions we added deprecation handle to make it succeed naughtily
Turns out we were one of the sites naughtily using the BAO directly who needed this handling
to work - but because we passed a number in quote it didn't - this fixes
Before
Deprecation handling works for 5 but not '5'
After
Deprecation handling works for 5 and '5'
Technical Details
Comments
We don't support calling the BAO directly but somethings we kinda try to be helpful anyway