Fix placeholder font in Quicksearch

[pfigel]

Overview

This is a fairly trivial change to ensure the placeholder text shown in the Quicksearch input uses the same font as the rest of the menu.

Before

The Quicksearch placeholder font is set to "FontAwesome", causing it to fall back to the default UA font for regular text:

After

Civi's default font is used:

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This is cool. I wasn't aware that you can mix different fonts together like this to get icons + text.

However, this raises a bigger question for me, which is that there is no default font for the CiviCRM menubar, or really anything in CiviCRM. As far as I can tell, CiviCRM's fonts just blow in the wind whichever way the CMS theme sets them. And IMO we should fix this!

Where did you get the idea that the menu uses Veranda by default?

[pfigel]

Where did you get the idea that the menu uses Veranda by default?

This is what I get for only using Civi with Drupal. 😄

Definitely gets more complicated with that in mind. I guess if we want to be consistent, we'd not enforce a specific font there, and use whatever the CMS gives us, but I don't see a straightforward way of doing that if we want to use font-family: 'FontAwesome' at the same time.

There are some bits in civicrm.css where we set font-family: Arial, Helvetica, sans-serif;, perhaps re-using that (with FontAwesome thrown in the mix) would at least be ... not more inconsistent? ... while fixing the odd "fallback to default UA" look?

Setting a default font would work as well, but that feels like a bigger change with some potential for headaches for people with custom themes.

[pfigel]

@colemanw I've updated this to not enforce any specific font for the placeholder, but rather the sans-serif pseudo-font. That one should at least look a little less out of place than the serif one currently used.

It should not introduce any issues for theming as any CSS that would target that specific element would've already had to overwrite the existing font-family.

[colemanw]

I'm still a little troubled by the fact that civicrm has no font. But I seem to be in the minority, so let's put that debate aside for now and merge this.