dev/translation#26 Fix Notice errors caused by l10n rewriting of quer… #14152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y so query outputed create view rather than the create table
|
(Standard links)
|
|
Iirc turning on multilingual adds fields to tables and views to db but is not supposed to add new tables. @Monish when you get back Wedneaday could you review this? |
|
Tested, fixes the notice errors. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y so query outputed create view rather than the create table
Overview
This fixes a undefined property notice error because the query was returning the CREATE View statement rather than the create table statement because the query was being re-written
Before
Undefined property notice shows
After
No notice
ping @JoeMurray @mlutfy @monishdeb