Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Extract get cfields function #14151

Merged
merged 1 commit into from
Apr 28, 2019
Merged

[REF] Extract get cfields function #14151

merged 1 commit into from
Apr 28, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor extraction

Before

Less readable

After

More readable

Technical Details

Simple extraction

Comments

@civibot
Copy link

civibot bot commented Apr 27, 2019

(Standard links)

@civibot civibot bot added the master label Apr 27, 2019
@seamuslee001
Copy link
Contributor

Extraction makes sense, reviewed the code confirmed its a clean extraction merging

@seamuslee001 seamuslee001 merged commit 039d7c8 into civicrm:master Apr 28, 2019
@seamuslee001 seamuslee001 deleted the dedupe7 branch April 28, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001