-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(REF) Standardize UFField create function #14084
Conversation
(Standard links)
|
9563482
to
3963d91
Compare
@eileenmcnaughton this fixes a bug caused by my last PR #14041 |
@colemanw I took a look at this but I feel nervous that there are lots of changes under the banner 'cleanup' in here & I don't feel confident that I would pick up if there is an error in here on doing code review |
@eileenmcnaughton since the BAO should now be acting in a standard way, I've taken it off the syntaxConformanceTest blacklist, which should help with your nervousness :) |
Adding |
I think given that with the syntax conformance test passing then i think we are ok with this refactor here. I'm going to merge this on the basis it fixes an error and that 5.14 is not yet in RC so have time to test |
Overview
Makes UFField::create act more like other BAO::create functions.
Also fixes a bug introduced in #14041 where Formatting fields cannot be created in the API or UI
Before
Nonstandard quirky function.
Adding a Formatting field to a profile broken on master branch.
After
More reasonable function.
Fixed adding a Formatting field to a profile.
.