Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REF) Standardize UFField create function #14084

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 18, 2019

Overview

Makes UFField::create act more like other BAO::create functions.
Also fixes a bug introduced in #14041 where Formatting fields cannot be created in the API or UI

Before

Nonstandard quirky function.
Adding a Formatting field to a profile broken on master branch.

After

More reasonable function.
Fixed adding a Formatting field to a profile.
.

@civibot
Copy link

civibot bot commented Apr 18, 2019

(Standard links)

@civibot civibot bot added the master label Apr 18, 2019
@colemanw colemanw force-pushed the UFFieldBAO branch 2 times, most recently from 9563482 to 3963d91 Compare April 19, 2019 13:42
@colemanw
Copy link
Member Author

@eileenmcnaughton this fixes a bug caused by my last PR #14041

@eileenmcnaughton
Copy link
Contributor

@colemanw I took a look at this but I feel nervous that there are lots of changes under the banner 'cleanup' in here & I don't feel confident that I would pick up if there is an error in here on doing code review

@colemanw
Copy link
Member Author

@eileenmcnaughton since the BAO should now be acting in a standard way, I've taken it off the syntaxConformanceTest blacklist, which should help with your nervousness :)

@colemanw
Copy link
Member Author

Adding has-test label because this PR adds syntaxConformanceTest coverage to the UFField api.

@seamuslee001
Copy link
Contributor

I think given that with the syntax conformance test passing then i think we are ok with this refactor here. I'm going to merge this on the basis it fixes an error and that 5.14 is not yet in RC so have time to test

@seamuslee001 seamuslee001 merged commit 00fff0a into civicrm:master Apr 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the UFFieldBAO branch April 24, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants