Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#881 Add in unit test demonstrating issue Stoob found with is… #14073

Merged
merged 1 commit into from
Apr 20, 2019
Merged

dev/core#881 Add in unit test demonstrating issue Stoob found with is… #14073

merged 1 commit into from
Apr 20, 2019

Conversation

seamuslee001
Copy link
Contributor

…_override

Overview

This is a unit test that demonstrates the bug 14059 is trying to solve

Before

No unit test

After

unit test demonstrating the bug

ping @Stoob @eileenmcnaughton

@civibot civibot bot added the master label Apr 16, 2019
@civibot
Copy link

civibot bot commented Apr 16, 2019

(Standard links)

@seamuslee001
Copy link
Contributor Author

Test failure relates here but should be fixed by #14059

@seamuslee001
Copy link
Contributor Author

jenkins re test this please

@seamuslee001
Copy link
Contributor Author

@colemanw wanna give this merge on pass given you have merged Stoob's PR now?

@seamuslee001
Copy link
Contributor Author

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 0c287d9 into civicrm:master Apr 20, 2019
@seamuslee001 seamuslee001 deleted the dev_core_881_unit_test branch April 20, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @colemanw