Make DAO fields more consistent #14072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd 'where' param Import & export have been hopelessly overloaded & misued in the code. One reason is that without them 'where' is not present. Logically import & export should have a narrow usage and should not be a pre-requisite for being available as a search field, in reality not so much. This simply makes the 'where' field available regardless of the presence of these fields By doing this we can make the metadata in the Query object able to handle more fields without special handling (e.g Contribution Recur fields)
|
(Standard links)
|
|
This seems sensible to me adding merge on pass |
|
Jenkins re test this please |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently the 'where' field is only populated when 'import' or 'export' is TRUE. This is part of why we have such an overloading of import & export. The BAO_Query class generally loads & handles metadata for fields where import is true. I believe this evolved by people trying to use what was there rather than made sense at any point in time.
I think that we can move towards simplifying some of our metadata based magic by trying to get the meaning of import & export closer to the original intent.
This PR makes is so the 'where' field is populated regardless of whether import or export is set. (A case could be made that it's easily calculable but there are places in the code that use it so better for it to be consistent for now IMHO).
Before
Where key only present when import or export = true
After
Where key present for all fields
Technical Details
I also added code so headerPattern & dataPattern display depended on not being empty rather than import / export. I would be just as happy with 'always set, even if empty'
This is the actual tpl change
bf144e7
The 'schema::' change is formatting compliance
Comments