[REF] Clean up CRM_Contribute_Form_SearchTest

[eileenmcnaughton]

Overview

Clean up test class to use a data provider

Before

Code more messy

After

Code more tidy

Technical Details

This is mostly about switching to a data provider to include flexibility & re-usability
of the test. Also fix some funkiness with tear down

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Adding merge on pass. It's a test refactor so by definition if it passes it works.