Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure edit tooltip is always initially hidden in contact summary block #14065

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

colemanw
Copy link
Member

Overview

Fixes eileenmcnaughton/org.wikimedia.relationshipblock#19
When a user does not have permission to edit a contact summary block, the little "Edit" tooltip should be hidden.

Before

Edit tooltip appears and is not styled.

After

Edit tooltip hidden except when hovering over an editable block.

Comments

Core blocks do not need this because they hide the tooltip in the smarty template. That's fine but if an extension author forgets to do that, this will ensure it still looks right.

@civibot
Copy link

civibot bot commented Apr 16, 2019

(Standard links)

@civibot civibot bot added the master label Apr 16, 2019
@eileenmcnaughton eileenmcnaughton merged commit 00d2fbf into civicrm:master Apr 16, 2019
@eileenmcnaughton eileenmcnaughton deleted the summaryBlock branch April 16, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allows Edit when only View permission is given
2 participants