dev/core#553: Creating new event takes value from default value not from saved template for custom fields

[monishdeb]

Overview

When creating a new event using a template the new event screen is taking the default values directly from the custom fields, and not from what's saved in the event template.

Steps to replicate:

1. Create a custom field for Events
2. Set default value say 'abc' for that custom field
3. Create/Edit an event template and save with custom field value say 'def'
4. Now create a new event using that event template

Issue - Custom field is set to default value 'abc' instead of 'def'

Before

After

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pradpnayak]

I tested this and it works fine

Before:

After:

GOOD TO MERGE!

[yashodha]

@monishdeb @pradpnayak tested this, works as expected and safe to merge.

[scoobird]

Hi folks. In dev/core/issues/553 I identified a possible regression with saving values to custom fields in events. Were you not able to replicate that?

[yashodha]

@scoobird yes, thanks for pointing that out.

@monishdeb can you please revert this as this is not respecting the new input values

[eileenmcnaughton]

@monishdeb @pradpnayak @scoobird - @yashodha created the revert commit & I merged it - It would be good to get it re-fixed but I agreed with @yashodha's analysis that a quick revert is the right first step since this was only just merged