Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu config screen improvements #14002

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 8, 2019

Overview

Live-updates to the menubar when adding/editing menu items on the admin screen.
Adds links to related settings pages to reduce confusion about how to configure various aspects of the menubar.
Fixes broken icon picker and missing Civi icon.

Before

  • Missing Civi icon
  • Broken icon picker for menu items.
  • Yellow alert appears with a "refresh page" link.
  • No links to related menu settings.

image

After

  • Fixed Civi icon
  • Fixed menu item icon picker
  • Live refresh of menubar, no need for yellow alert.
  • Added some links to related settings.

image

@civibot
Copy link

civibot bot commented Apr 8, 2019

(Standard links)

@civibot civibot bot added the master label Apr 8, 2019
@eileenmcnaughton
Copy link
Contributor

This really just affects the one page. I gave it a spin & it seemed to work well. Merging

@eileenmcnaughton eileenmcnaughton merged commit fd790e1 into civicrm:master Apr 9, 2019
@eileenmcnaughton eileenmcnaughton deleted the menuConfig branch April 9, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants