dev/core#830 Expose cancel_reason field by cleaning up the cancel template to use entity field template #13997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add cancel reason field to form to cancel recurring contributions
Before
As seen by a back-office user
After
As seen by a back-office user
As seen by a 'self service' user - ie someone without edit contributions permission
Exposed on view form
Technical Details
Needed #13993 to be merged first
@mattwire I think this will conclude this round of cleanup on the recurring forms for me - we now have a shared parent for the 3 forms using the entity form. Ideally more of that subscription wrangling would be moved to the shared parent in a later round but this takes us forwards in terms of code quality / use of metadata.
I'm going to look a bit more at the search side of it though before closing this piece of work