Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#830 Expose cancel_reason field by cleaning up the cancel template to use entity field template #13997

Merged
merged 1 commit into from
May 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 8, 2019

Overview

Add cancel reason field to form to cancel recurring contributions

Before

Screenshot 2019-04-08 14 18 11

As seen by a back-office user
Screen Shot 2019-04-25 at 4 17 13 PM

After

As seen by a back-office user
Screen Shot 2019-04-25 at 4 03 25 PM

As seen by a 'self service' user - ie someone without edit contributions permission
Screen Shot 2019-04-25 at 4 01 06 PM

Exposed on view form
Screen Shot 2019-04-25 at 4 13 51 PM

Technical Details

Needed #13993 to be merged first


@mattwire I think this will conclude this round of cleanup on the recurring forms for me - we now have a shared parent for the 3 forms using the entity form. Ideally more of that subscription wrangling would be moved to the shared parent in a later round but this takes us forwards in terms of code quality / use of metadata.

I'm going to look a bit more at the search side of it though before closing this piece of work

@civibot
Copy link

civibot bot commented Apr 8, 2019

(Standard links)

@civibot civibot bot added the master label Apr 8, 2019
@eileenmcnaughton eileenmcnaughton changed the title [wip]dev/core#830 Expose cancel_reason field by cleaning up the cancel template to use entity field template dev/core#830 Expose cancel_reason field by cleaning up the cancel template to use entity field template Apr 25, 2019
@eileenmcnaughton
Copy link
Contributor Author

@mattwire can you take a look at this one?

@eileenmcnaughton
Copy link
Contributor Author

@mattwire thoughts on this?

@mattwire
Copy link
Contributor

Tested and I'm happy with this

@mattwire mattwire merged commit a99f695 into civicrm:master May 25, 2019
@eileenmcnaughton eileenmcnaughton deleted the recur_entity branch May 25, 2019 23:22
@eileenmcnaughton
Copy link
Contributor Author

@mattwire yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants