Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(NFC) Update various files to pass current phpcs #13978

Merged
merged 5 commits into from
Apr 6, 2019
Merged

(NFC) Update various files to pass current phpcs #13978

merged 5 commits into from
Apr 6, 2019

Conversation

totten
Copy link
Member

@totten totten commented Apr 5, 2019 •
edited
Loading

Overview

We recently updated test infrastructure to use a newer version of phpcs (2.1=>2.9), which leads to some slightly different linting results. This cleans various files.

Process

  • Run phpcbf-civi on all *.php files to do automated fixups.
  • Inspect output. Some results look wonky -- find a different/better way to format these.
  • Run phpcs-civi on all *.php files.
  • Manually inspect/update any files that still report issues.

@civibot
Copy link

civibot bot commented Apr 5, 2019

(Standard links)

@civibot civibot bot added the master label Apr 5, 2019
@totten
Copy link
Member Author

totten commented Apr 5, 2019

jenkins, test this please

@totten totten mentioned this pull request Apr 5, 2019
Merged
@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@totten totten merged commit 1060aa8 into civicrm:master Apr 6, 2019
@totten totten deleted the master-phpcbf branch April 6, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totten @seamuslee001