Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment test cleanup #13924

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Payment test cleanup #13924

merged 1 commit into from
Apr 1, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 1, 2019 •
edited
Loading

Overview

Minor test cleanup

Before

checkPaymentResult called

After

array comparison done more transparently, also array formatting cleanup

Technical Details

Comments

@civibot civibot bot added the master label Apr 1, 2019
@civibot
Copy link

civibot bot commented Apr 1, 2019

(Standard links)

@eileenmcnaughton
Simply test, checkPaymentResult adds no value
52746f6 
calling the checkPaymentResult function is actually decreasing readability here as the
simple array comparison is being made to look complex
@eileenmcnaughton
Copy link
Contributor Author

Unrelated fail - self merging as just test cleanup

@eileenmcnaughton eileenmcnaughton merged commit 46e0ade into civicrm:master Apr 1, 2019
@eileenmcnaughton eileenmcnaughton deleted the payment_test branch April 1, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eileenmcnaughton