Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert trxn_date field in the Update Pending Status task option from… #13918

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Mar 29, 2019

… find contributions to datepicker from jcalendar

Overview

This converts the transaction date field on the update pending status task from being done using jcalendar to being a datepicker

Before

Legacy jcalendar used
Screenshot 2019-04-01 14 17 07

After

Modern Datepicker used

Screenshot 2019-04-01 14 17 07

ping @eileenmcnaughton @monishdeb @mattwire

… find contributions to datepicker from jcalendar
@civibot
Copy link

civibot bot commented Mar 29, 2019

(Standard links)

@civibot civibot bot added the master label Mar 29, 2019
@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

Seems no worse after the change.... I note that appending the current time doesn't make any sense if the date is not today but it seems bad but is equally bad before this.

@eileenmcnaughton eileenmcnaughton merged commit cb7f35b into civicrm:master Apr 1, 2019
@eileenmcnaughton eileenmcnaughton deleted the trxn_date_conversion branch April 1, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants